Repository navigation
plugin/bound: cancel deferred select binding on disposal - #72
Merged
Merged
Conversation
For `<select>`, x-bound sets up its effect and change listener in a setTimeout, so that options rendered by x-for exist by then. If the element was destroyed before the timer fired, for example by an x-if toggled within the same tick, both were created after the directive's cleanups had already run and were never released: the detached select kept following the bound property and writing it back on change. Clear the timer on cleanup.
📦 Bundle size comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
<select>,x-boundsets up its effect and change listener in asetTimeout, so that options rendered byx-forexist by then. If the element was destroyed before the timer fired, for example by anx-iftoggled within the same tick, both were created after the directive's cleanups had already run and were never released: the detached<select>kept following the bound property and writing it back on change.Clear the timer on cleanup.